Conversation
…e atomicWriteUriTextWithFs to handle existing targets. Update tests to reflect changes in file system error handling and add new test for atomic write behavior.
…larity. Updated import path for parseVtt and enhanced type annotations for targetCells and alignedTextCell. This ensures better alignment with TypeScript practices.
…index. Changed parseVtt import to use the correct file extension and exported parseFile from index.tsx for improved module accessibility.
…y. Updated comments for better understanding of temp file cleanup process and changed variable names for consistency.
…g to enhance cleanup logic. This change ensures that the temporary file is only deleted if it was successfully created, improving error handling and clarity in the process.
…leanup logic. Added try-finally block to ensure temporary directory is removed after test execution, ensuring better resource management.
LeviXIII
left a comment
LeviXIII
left a comment
There was a problem hiding this comment.
We chatted about the changes to the percentage bars/circles and main menu changes.
LeviXIII
left a comment
LeviXIII
left a comment
There was a problem hiding this comment.
For this one, the 100% at the bottom should be hidden until someone hovers on the bar. The popup should also just show the Completed percentage as 100%
One last issue I saw was when changing the number of validations in the main menu. If you immediately go to the navigation webview, the percentages won't change. This may be due to your change with the content not being flushed after closing, but I'm sure we can just double check the logic for communicating a change to the navigation webview.
LeviXIII
left a comment
LeviXIII
left a comment
There was a problem hiding this comment.
One more fix (hopefully): for some reason, in the forked-zhuang-eastern project, Mark is showing that there is 6% of completed validation without there being any progress. I looked through the json to see that there WAS progress, but the value was deleted and it is now empty. It seems like the empty value is being counted towards progress still. Maybe it's not registering the "isDeleted" key in the json? Either way, can you investigate this on your branch since it's related? Here is the json:
{
"kind": 2,
"languageId": "scripture",
"value": "",
"metadata": {
"type": "text",
"id": "c1e0761c-f984-b627-ff22-521973d3eb11",
"data": {
"globalReferences": [
"MRK 1:4"
]
},
"edits": [
{
"editMap": [
"value"
],
"value": "<span>Goran, Shixizhe Yuehan chuxian le, ta zai kuangye xujiang hui gai jiu de she zui de xili.</span>",
"timestamp": 1758121447731,
"type": "llm-generation",
"author": "randall",
"validatedBy": []
},
{
"editMap": [
"value"
],
"value": "<span><br></span><p><span style=\"color: rgb(204, 204, 204);\">果然，施洗者 约翰 出现了，他在旷野宣讲悔改就得赦罪的洗礼。</span></p>",
"timestamp": 1758121637813,
"type": "user-edit",
"author": "randall",
"validatedBy": [
{
"username": "randall",
"creationTimestamp": 1758121637813,
"updatedTimestamp": 1758121641463,
"isDeleted": true
}
]
},
{
"editMap": [
"value"
],
"value": "<span><span style=\"color: rgb(204, 204, 204);\">果然，施洗者 约翰 出现了，他在旷野宣讲悔改就得赦罪的洗礼。</span></span>",
"timestamp": 1758121647794,
"type": "user-edit",
"author": "randall",
"validatedBy": [
{
"username": "randall",
"creationTimestamp": 1758121647794,
"updatedTimestamp": 1758121651331,
"isDeleted": true
}
]
},
{
"editMap": [
"value"
],
"value": "",
"timestamp": 1758833887112,
"type": "user-edit",
"author": "randall",
"validatedBy": [
{
"username": "randall",
"creationTimestamp": 1758833887112,
"updatedTimestamp": 1758833887112,
"isDeleted": false
}
]
}
],
3 participants
No description provided.